Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Slug for Single Quotes #392

Closed
rojenzaman opened this issue Apr 16, 2022 · 6 comments
Closed

URL Slug for Single Quotes #392

rojenzaman opened this issue Apr 16, 2022 · 6 comments

Comments

@rojenzaman
Copy link
Contributor

The amuse wiki converts quotes to "-" when createing url slug.

like:
Emma Goldman'ın Hayatı
to:
emma-goldman-in-hayati

But is wrong for Turkish, in our language we are often use quotes to separate noun suffixes, converting quotes to hyphens in kebab URLs is annoying.

we would like to see this:
emma-goldmanin-hayati

Can URL conversion rules be changed without accessing the server?

melmothx added a commit that referenced this issue Apr 17, 2022
@melmothx
Copy link
Owner

melmothx commented Apr 17, 2022 via email

@rojenzaman
Copy link
Contributor Author

rojenzaman commented Apr 18, 2022

Now, in theory there could be a language specific way to asciify the
URI, but I'm wondering if it's doable or wise. For example, there could
be cases where you would want the hyphen instead, and not just stripped
out, so I'm leaning toward the manual way.

Thoughts?

There may be scenarios where both situations occur. You are right. It is a complicated situation. If the language-specific asciiization option is not possible, I think the following two features should be added:

  1. Suggested converted URI: I think it is necessary to add a pre-made converted URI to the URI select box so that anyone who is satisfied or dissatisfied with the URI has a chance to play with it.

  2. Changing the URI after the text is created: What do we do if we are not satisfied with the URI of the previously generated text? In the current case it is necessary to create a new text and redirect the old text to the new URI. It's a pretty tough road. Could users be given the ability to change the URI of the created text instead? The old URI can then be arbitrarily redirected to the new URI.

@melmothx
Copy link
Owner

melmothx commented Apr 18, 2022 via email

@rojenzaman
Copy link
Contributor Author

Thanks a lot for considering all of those!

melmothx added a commit that referenced this issue Apr 23, 2022
@melmothx
Copy link
Owner

@rojenzaman For the first feature, please give it a try here: https://staging.amusewiki.org/action/text/new

@rojenzaman
Copy link
Contributor Author

I have tried it works pretty.

melmothx added a commit that referenced this issue Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants