Default zero dot display register to the 24 bit integer limit #1968
Conversation
nadiaholmquist
force-pushed
the
master
branch
from
10c70eb
to
a7575ec
Compare
it goes through the reset function to set the variable on boot anyway but why not have the initialized state be correct too
| @@ -197,7 +197,7 @@ class GPU3D | |||
|
|
|||
| FIFO<CmdFIFOEntry, 64> CmdStallQueue {}; | |||
|
|
|||
| u32 ZeroDotWLimit = 0; | |||
| u32 ZeroDotWLimit = 0xFFFFFF; | |||
There was a problem hiding this comment.
doesn't this need to be changed in Reset?
There was a problem hiding this comment.
i did change it there, i just now also changed the variable's default value to look pretty/avoid confusion.
There was a problem hiding this comment.
though looking at it now no other variable gets initialized in gpu3d.h to its actual default as stated in the reset function
so maybe i should revert that change to avoid inconsistency?
There was a problem hiding this comment.
there isn't really a reason for the variables to be initialised in the header, except to prevent UB in case they are read before Reset is called (though that shouldn't happen if that makes any sense).
There was a problem hiding this comment.
yeah, so it's mostly just personal preference what value they get initialized to
i wont worry about it
if someone wants it changed back for consistency with the other values being 0 initialized I can revert that change easily
fixes: #1143
fixes a fail on one of Striker's line test roms
tested via this test rom installed to nand as DSiware on a new3DS: testdepth.zip
default behavior appears to be that it renders all the way up to the 24 bit integer limit (at which point it overflows to 0)