Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop pulling unauthenticated upstreams #3005

Closed
wants to merge 30 commits into from
Closed

Conversation

glyph
Copy link

@glyph glyph commented Aug 9, 2015

This will undoubtedly break many of these projects, but that's the point. HTTPS is literally free, anyone can have it, it takes only a few minutes to set up, and while you wait you can use free HTTPS-enabled hosts like Github.

@glyph
Copy link
Author

glyph commented Aug 9, 2015

This addresses #3004 .

@glyph
Copy link
Author

glyph commented Aug 9, 2015

This is obviously quite a large PR with a lot of changes; I'm not sure it can land as-is (certainly not until I can figure out what's wrong with the CI). I hope it can serve as a useful starting point for a discussion about what needs to change to avoid the possibility of trivial compromise via malware being injected on the wiki, or into a connection to a CVS repository.

@milkypostman
Copy link
Member

hey, this is still on my radar. I really like the idea, think we need to consider how to get it merged in soon. just letting you know it's not being ignored.

@glyph
Copy link
Author

glyph commented Aug 17, 2015

@milkypostman - thanks for the update. I am glad that this is on your mind :).

dunn added a commit to dunn/melpa that referenced this pull request Dec 26, 2015
@dunn dunn mentioned this pull request Dec 26, 2015
dunn added a commit to dunn/melpa that referenced this pull request Dec 26, 2015
jeffgran pushed a commit to jeffgran/melpa that referenced this pull request Jan 5, 2016
@tarsius
Copy link
Member

tarsius commented Sep 19, 2016

What in this pull request is still relevant and what is not? @glyph, I think you would have a better chance of getting at least some of this merged if you split it up into multiple branches (but I would recommend against opening more than one or two new pull requests initially). For example, I don't think emacswiki support is going to be dropped any time soon, but the various http => https changes would likely be accepted without much discussion. In any case, rebasing would help.

@glyph
Copy link
Author

glyph commented Sep 19, 2016

@tarsius I always thought it was unlikely that this could be merged as-is :). I'll try to start splitting this up as I have time.

@tarsius
Copy link
Member

tarsius commented Sep 19, 2016

I am closing this then as there also is #3004.

@tarsius tarsius closed this Sep 19, 2016
@glyph
Copy link
Author

glyph commented Sep 19, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants