Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary: Some calendar dates for Norway #4179

Merged
merged 1 commit into from Aug 28, 2016

Conversation

unhammer
Copy link
Contributor

@purcell
Copy link
Member

purcell commented Aug 27, 2016

Thanks! Quick feedback:

  • Please remove the redundant "for Emacs" from the package description line
  • It's very unusual placing eval-after-load forms inside a function. Why would you not just put all the code that's in calendar-norway-common-settings at the top level of the file instead?

@unhammer
Copy link
Contributor Author

Thanks for the feedback =D Both are implemented now. I guess lazy-loading like that was a bit overkill …

@purcell purcell merged commit c5d0123 into melpa:master Aug 28, 2016
@purcell
Copy link
Member

purcell commented Aug 28, 2016

Yay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants