Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dired-hide-dotfiles recipe #4614

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Add dired-hide-dotfiles recipe #4614

merged 1 commit into from
Mar 13, 2017

Conversation

mattiasb
Copy link
Contributor

@mattiasb mattiasb commented Mar 8, 2017

Brief summary of what the package does

Hide dotfiles in dired.

Direct link to the package repository

https://github.com/mattiasb/dired-hide-dotfiles

Your association with the package

I'm the maintainer.

Relevant communications with the upstream package maintainer

None needed

Checklist

  • [ ✓ ] I've read CONTRIBUTING.md
  • [ ✓ ] I've used package-lint to check for packaging issues, and addressed its feedback
  • [ ✓ ] I've built and installed the package using the instructions in the README

@syohex
Copy link
Contributor

syohex commented Mar 8, 2017

I think dired-filter provides same feature and more features about filtering. How about ?

Review memo

  • This package does not use any Emacs 25.1 features, it works on Emacs 24.1

@mattiasb
Copy link
Contributor Author

mattiasb commented Mar 8, 2017

Are there an easy way to check what version is required for your code?

Yeah I tried dired-filter before writing this. It has a rather advanced concept of filtering that felt interesting but kind of got in the way for me. All i wanted was a simple toggle-mode, similar to dired-omit but for dot-files.

mattiasb added a commit to mattiasb/dired-hide-dotfiles that referenced this pull request Mar 8, 2017
According to Syohex¹ we only need Emacs 24.1 for this package, so pull
the requirement down a bit.

1: melpa/melpa#4614 (comment)
@mattiasb
Copy link
Contributor Author

mattiasb commented Mar 8, 2017

Pushed a 25.124.1 Requires-fix.

@purcell
Copy link
Member

purcell commented Mar 8, 2017

Are there an easy way to check what version is required for your code?

You'd really need to test with other versions to be sure. But package-lint will at least warn you about uses of functions/libraries added in Emacs versions newer than the one in your Package-Requires header.

@mattiasb
Copy link
Contributor Author

mattiasb commented Mar 8, 2017

Yeah that's what I gathered. I don't have easy access to older versions of Emacs though. Personally I'd prefer just going back to the 25.1 require, since that's what I've tested for, but either is fine with me.

@purcell
Copy link
Member

purcell commented Mar 9, 2017

Cool, then we're good to merge, but I'd ask you to first remove the redundant :files spec in the recipe entirely please.

@mattiasb
Copy link
Contributor Author

mattiasb commented Mar 9, 2017

Ok, so basically:

  1. Fix the recipe
  2. Go back to 25.1?

@mattiasb
Copy link
Contributor Author

mattiasb commented Mar 9, 2017

Done in the package here and force-pushed an updated recipe.

@syohex
Copy link
Contributor

syohex commented Mar 10, 2017

@mattiasb
Copy link
Contributor Author

I believe you have to escape both the backslash and the dot. That is \\\ and \...

@xuchunyang
Copy link
Contributor

xuchunyang commented Mar 10, 2017

@mattiasb The regexp is ^\., in Elisp string, it is written as "^\\.", though "^\\\." is the same, but you don't need (and should not) to escape . in Elisp string, since it is confusing.

(string= "^\\." "^\\\.")
     => t

@tarsius tarsius added recipes awaiting-upstream Awaiting action from an upstream maintainer labels Mar 12, 2017
@mattiasb
Copy link
Contributor Author

You are correct of course. :)

Fixed!

@syohex syohex removed the awaiting-upstream Awaiting action from an upstream maintainer label Mar 13, 2017
@syohex syohex merged commit ba64a50 into melpa:master Mar 13, 2017
@syohex
Copy link
Contributor

syohex commented Mar 13, 2017

Merged

@mattiasb
Copy link
Contributor Author

Thanks! :)

@Boruch-Baum
Copy link
Contributor

@syohex wrote: #4614 (comment)

I think dired-filter provides same feature and more features about filtering. How about ?

This package can result in a TRIPLE over-do, because emacs itself has dired-omit-mode built-in, so a user could potentially end up being confused by the three packages. Package dired-filter does warn that its own omit-mode filter should not be used in conjunction with dired-omit-mode itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants