Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner-comment #5380

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Add banner-comment #5380

merged 1 commit into from
Apr 2, 2018

Conversation

WJCFerguson
Copy link
Contributor

Brief summary of what the package does

Trivial Emacs package to format a comment as a banner. Will reformat an existing banner.

Direct link to the package repository

https://github.com/WJCFerguson/banner-comment

Your association with the package

I'm the maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

@purcell
Copy link
Member

purcell commented Mar 25, 2018

Thanks, this looks handy!

  • There's some package-lint feedback you've missed here.
  • I suggest you use the standard more verbose header boilerplate which makes the licence explicit.
  • Where you've hard-coded 80 as the default width, I suggest you use the value of the fill-column variable, which users who prefer longer or shorter lines will already have set according to their preferences.

@WJCFerguson
Copy link
Contributor Author

Good feedback thanks, I'll address those items. The 80 column thing occurred to me after submitting.

@WJCFerguson
Copy link
Contributor Author

Right, should have resolved those now...

@WJCFerguson
Copy link
Contributor Author

Oh - I just read your suggestion properly for fill-column - instead I made it another variable. fill-column sounds more sensible... I'll change it to that.

@purcell purcell merged commit 4bb69f1 into melpa:master Apr 2, 2018
@purcell
Copy link
Member

purcell commented Apr 2, 2018

Great, merged now. Welcome to MELPA! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants