Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes/ccls #5405

Merged
merged 1 commit into from
May 12, 2018
Merged

Add recipes/ccls #5405

merged 1 commit into from
May 12, 2018

Conversation

MaskRay
Copy link
Contributor

@MaskRay MaskRay commented Apr 1, 2018

Brief summary of what the package does

emacs-ccls is a client for ccls (forked from cquery), a C/C++ language server.

Direct link to the package repository

https://github.com/MaskRay/ccls

Your association with the package

Maintainer.

Relevant communications with the upstream package maintainer

[e.g., package.el compatibility changes that you have submitted. Write None needed if there is no problem.]

Checklist

Please confirm with x:

@MaskRay
Copy link
Contributor Author

MaskRay commented Apr 1, 2018

I am a main contributor of both cquery and its Emacs plugin emacs-cquery. This fork is because of our disagreement about the roadmap of the project. Long story. I will also create Arch Linux packages as follow-up.

ccls removes ~3000 lines of cquery's original code (switches to C++17, removes a lot of third-party code, ...) and I will make other improvement to the index and other aspects. The original author of cquery has switched to a different PR model and I won'g be able to push my drastic changes (lost my push access) so I have to make my own fork.

@tarsius
Copy link
Member

tarsius commented May 10, 2018

@purcell Please have a look at this. I don't know how you feel about this sort of fork.

@purcell
Copy link
Member

purcell commented May 11, 2018

Where's the elisp? It's certainly not included in the provided recipe, and your wiki page here links to a non-existent location.

@MaskRay
Copy link
Contributor Author

MaskRay commented May 12, 2018

Code: https://github.com/MaskRay/emacs-ccls

The links on wiki have been updated. Thanks

See emacs-lsp/emacs-ccls#1 for some rationale

there is quite some difference now, the indexer.h import pipeline and upcoming clang c++ api

@purcell
Copy link
Member

purcell commented May 12, 2018

Cool, thanks. I'll go ahead and merge this now. I think it would be fair for you to mention in the README that this is a fork.

Please have a look at this. I don't know how you feel about this sort of fork.

This doesn't seem as capricious as some personal forks, so I'm fine with it: here, a key contributor of the old project has a different plan, but has not only created a fork but has also already made substantial changes. If there were only a plan to do things differently, that would be a different story.

@purcell purcell merged commit be27a40 into melpa:master May 12, 2018
@MaskRay MaskRay deleted the ccls branch May 12, 2018 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants