Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reykjavik-ish theme #5690

Closed
wants to merge 1 commit into from
Closed

Add Reykjavik-ish theme #5690

wants to merge 1 commit into from

Conversation

jssee
Copy link

@jssee jssee commented Aug 16, 2018

Brief summary of what the package does

A dark theme based on Reykjavik-theme

Direct link to the package repository

https://github.com/jssee/reykjavik-ish

Your association with the package

maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

@purcell
Copy link
Member

purcell commented Aug 30, 2018

Thanks, and sorry for the slow response!

You've got a package here with one name, but its contents are a file with a different name. The two have to match, so you must change the recipe to reykjavik-theme.

Re. the theme file itself:

  • May I suggest that "Theme" is not the best package description.
  • The deftheme form is also missing the description parameter.
  • The Commentary section is repeated and malformed, and its contents should be line-wrapped.
  • The Copyright header line is missing a name, and the year is presumably wrong.

Hope that helps!

@purcell purcell added the awaiting-upstream Awaiting action from an upstream maintainer label Aug 30, 2018
@jssee
Copy link
Author

jssee commented Sep 6, 2018

Hi sorry for the late response but the author of the original theme made updates that make this version not necessary. closing this now.

@jssee jssee closed this Sep 6, 2018
@jssee jssee deleted the jh/reykjavik-ish branch September 6, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting action from an upstream maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants