Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lsp-dart #5767

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Add lsp-dart #5767

merged 1 commit into from
Nov 9, 2018

Conversation

twlz0ne
Copy link
Contributor

@twlz0ne twlz0ne commented Oct 21, 2018

Brief summary of what the package does

Dart support for lsp-mode.

Direct link to the package repository

https://github.com/twlz0ne/lsp-dart

Your association with the package

Author&Maintainer

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

@twlz0ne
Copy link
Contributor Author

twlz0ne commented Oct 21, 2018

Screenshot

emacs-lsp-dart-1

@purcell
Copy link
Member

purcell commented Nov 9, 2018

Thanks. The commentary docs mention lsp-dart-enable, but that function isn't defined anywhere that I can see, so you might need to fix the doc.

Looks good otherwise, though, so merging now! :-)

@purcell purcell merged commit da22fe9 into melpa:master Nov 9, 2018
@twlz0ne
Copy link
Contributor Author

twlz0ne commented Nov 10, 2018

@purcell The lsp-dart-enable function is generated by lsp-define-stdio-client, for example:

;; lsp-foo.el
(lsp-define-stdio-client lsp-foo ...)

;; lsp-mode.el
(cl-defmacro lsp-define-stdio-client (name ...
  ...
  (let ((enable-name (intern (format "%s-enable" name))))
    `(progn
       ...
       (defun ,enable-name ()
 ...)

https://github.com/emacs-lsp/lsp-mode/blob/7f3971af37cf20fb42fea705951bba1708211497/lsp-mode.el#L167-L171

@purcell
Copy link
Member

purcell commented Nov 11, 2018

Oh cool, I did wonder if that was the case. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants