Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt counsel-gtags package #6093

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Adopt counsel-gtags package #6093

merged 1 commit into from
Apr 22, 2019

Conversation

FelipeLema
Copy link
Contributor

Brief summary of what the package does

Original counsel-gtags repo seems abandoned. I've tried contacting the author through pull requests and mail without success

Direct link to the package repository

https://github.com/FelipeLema/emacs-counsel-gtags

Your association with the package

Maintainer of the fork.

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

@Ergus
Copy link

Ergus commented Mar 26, 2019

I have been using the fork since some weeks ago and it fixes some of the issues in the original repo. I also tried to contact the initial developer some months without success. So the adoption is very recommended as soon as possible.

@purcell
Copy link
Member

purcell commented Apr 21, 2019

Thanks. Happy to merge this, but the new code needs to declare a package dependency on seq now that it has been changed to start using that library. (Sorry for the slow response, btw.)

@purcell purcell added the awaiting-upstream Awaiting action from an upstream maintainer label Apr 21, 2019
FelipeLema added a commit to FelipeLema/emacs-counsel-gtags that referenced this pull request Apr 22, 2019
seq.el was introduced in emacs 25.1 and included `seq-filter`

per melpa/melpa#6093 (comment)
@FelipeLema
Copy link
Contributor Author

@purcell updated package reqs in FelipeLema/emacs-counsel-gtags@3ebfd41

@purcell purcell merged commit fe8fe6a into melpa:master Apr 22, 2019
@purcell
Copy link
Member

purcell commented Apr 22, 2019

Great, thank you.

@FelipeLema FelipeLema deleted the emacs-counsel-gtags-adoption branch April 23, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting action from an upstream maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants