Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cell-mode recipe #7365

Closed
wants to merge 1 commit into from
Closed

add cell-mode recipe #7365

wants to merge 1 commit into from

Conversation

dto
Copy link

@dto dto commented Jan 13, 2021

Brief summary of what the package does

Cell-mode implements a customizable object-oriented spreadsheet user interface in an Emacs buffer.

Direct link to the package repository

https://gitlab.com/dto/cell-mode

Your association with the package

I am the author and maintainer.

Relevant communications with the upstream package maintainer

None needed.

Checklist

Please confirm with x:

  • The package is released under a GPL-Compatible Free Software License.
  • I've read CONTRIBUTING.org
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.org
  • I have confirmed some of these without doing them

Notes: In some spots Flycheck fails to detect docstrings after CL-DEFMETHOD. I use dynamic binding in the inner rendering loop, but I am planning to eliminate this.

@riscy
Copy link
Member

riscy commented Jan 18, 2021

Thanks. I was about to suggest you compare this to cell-mode, and then I realized this is that package, and it isn't indexed yet. :) Quick first pass --

cell-mode.el

byte-compile (using Emacs 27.1):

cell-mode.el:148:30:Warning: Package cl is deprecated
In cell-insert:
cell-mode.el:1392:28:Warning: reference to free variable `row'
cell-mode.el:1392:32:Warning: reference to free variable `col'
In cell-insert-blank:
cell-mode.el:1404:26:Warning: reference to free variable `row'
cell-mode.el:1404:30:Warning: reference to free variable `col'
In cell-insert-spacer:
cell-mode.el:1418:24:Warning: reference to free variable `row'
cell-mode.el:1418:28:Warning: reference to free variable `col'

checkdoc (using version 0.6.2):

Warning (emacs): 
cell-mode.el:254: All variables and subroutines might as well have a documentation string
Warning (emacs): 
cell-mode.el:326: All variables and subroutines might as well have a documentation string
Warning (emacs): 
cell-mode.el:354: All variables and subroutines might as well have a documentation string
Warning (emacs): 
cell-mode.el:363: All variables and subroutines might as well have a documentation string
Warning (emacs): 
cell-mode.el:672: All variables and subroutines might as well have a documentation string
Warning (emacs): 
cell-mode.el:1253: White space found at end of line

package-lint (using version 20200906.512):

1 issue found:
148:29: warning: Replace deprecated `cl' with `cl-lib'.  The `cl-libify' package can help with this.

Other lints:

  • cell-mode.el#L662: It's safer to sharp-quote function names; use #'
  • cell-mode.el#L663: It's safer to sharp-quote function names; use #'
  • cell-mode.el#L676: Optionally use unless ... instead of when (not ...)
  • cell-mode.el#L678: Optionally use unless ... instead of when (not ...)
  • cell-mode.el#L680: Optionally use unless ... instead of when (not ...)
  • cell-mode.el#L682: Optionally use unless ... instead of when (not ...)
  • cell-mode.el#L726: Optionally use unless ... instead of when (not ...)
  • cell-mode.el#L853: Optionally use unless ... instead of when (not ...)
  • cell-mode.el#L1226: Optionally use unless ... instead of when (not ...)
  • cell-mode.el#L1719: Optionally use unless ... instead of when (null ...)
  • cell-mode.el#L35: Prefer https over http if possible (why?)

@riscy
Copy link
Member

riscy commented Jan 24, 2021

I'll mark this awaiting upstream, but feel free to ping when ready for another look.

@riscy riscy added the awaiting-upstream Awaiting action from an upstream maintainer label Jan 24, 2021
@riscy
Copy link
Member

riscy commented Oct 2, 2021

Friendly ping. :)

@dto
Copy link
Author

dto commented Jan 15, 2022

Greetings @riscy , my sincere apologies for not answering these messages sooner, I did not see the notifications. I'm planning to revise cell-mode to make the changes you suggest. Thanks for your feedback and assistance!

@riscy riscy removed the awaiting-upstream Awaiting action from an upstream maintainer label Jan 16, 2022
@riscy
Copy link
Member

riscy commented Jan 16, 2022

No trouble! I'll re-mark this awaiting upstream for now but feel free to reach out.

@riscy riscy added the awaiting-upstream Awaiting action from an upstream maintainer label Jan 16, 2022
@tarsius
Copy link
Member

tarsius commented May 13, 2022

I am closing this pull-request because it is over a year old now. That doesn't mean that we won't add this to Melpa, just that you have to ask us to reopen it once you are ready.

(I am personally interested in this package and would like to see it added.)

@tarsius tarsius closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting action from an upstream maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants