Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package+: remove files keyword so it'll pick up new files #7380

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

zenspider
Copy link
Contributor

Brief summary of what the package does

Extensions for the package library.

Direct link to the package repository

https://github.com/zenspider/package

Your association with the package

Author

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

  • The package is released under a GPL-Compatible Free Software License.
  • I've read CONTRIBUTING.org
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.org
  • I have confirmed some of these without doing them

@zenspider
Copy link
Contributor Author

zenspider commented Jan 21, 2021

I assume I need to bump something in my repo to get a new package build w/ the added files?

@riscy
Copy link
Member

riscy commented Jan 24, 2021

I assume I need to bump something in my repo to get a new package build w/ the added files?

If it's just regular MELPA, there's nothing to bump -- we just take the latest commit. If it's MELPA stable and you want the version there updated, you'll need to tag a new release.

Since this package is already in MELPA I'll just merge this, but I'd strongly recommend adding a LICENSE file to the repository. I'll also take this opportunity to bring your attention to some of the latest MELPA guidelines below, and a (warm) invitation to followup here if you need clarification on any. :)

package+.el

byte-compile (using Emacs 27.1):

package+.el:96:1:Warning: Package cl is deprecated
package+.el:96:1:Warning: cl package required at runtime
In package-delete-by-name:
package+.el:132:9:Warning: assignment to free variable `package+-dirty'
In package-maybe-install:
package+.el:139:11:Warning: assignment to free variable `package+-dirty'
In package-manifest:
package+.el:240:16:Warning: assignment to free variable `package+-dirty'
package+.el:239:38:Warning: reference to free variable `package+-dirty'

checkdoc (using version 0.6.2):

Warning (emacs): 
package+.el:115: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:117: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:120: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:130: First sentence should end with punctuation
Warning (emacs): 
package+.el:150: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:153: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:156: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:164: First sentence should end with punctuation
Warning (emacs): 
package+.el:164: Argument `pred' should appear (as PRED) in the doc string
Warning (emacs): 
package+.el:164: Lisp symbol `map-filter' should appear in quotes
Warning (emacs): 
package+.el:169: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:179: All variables and subroutines might as well have a documentation string
Warning (emacs): 
package+.el:189: All variables and subroutines might as well have a documentation string

package-lint (using version 20210111.341):

29 issues found:
1:0: warning: The package summary should not end with a period.
94:10: error: You should depend on (emacs "24.5") if you need `cl-extra'.
97:12: warning: Replace deprecated `cl' with `cl-lib'.  The `cl-libify' package can help with this.
99:0: error: "package-disable-cleanup" doesn't start with package's prefix "package+".
104:0: error: "package-disable-record" doesn't start with package's prefix "package+".
111:0: error: Define compatibility functions with a prefix, e.g. "package+--package-desc-version", and use `defalias' where they exist.
115:0: error: "symbol<" doesn't start with package's prefix "package+".
117:0: error: "symbol-list<" doesn't start with package's prefix "package+".
119:0: error: "package-details-for" doesn't start with package's prefix "package+".
125:0: error: "package-version-for" doesn't start with package's prefix "package+".
129:0: error: "package-delete-by-name" doesn't start with package's prefix "package+".
135:0: error: "package-maybe-install" doesn't start with package's prefix "package+".
142:0: error: "package-deps-for" doesn't start with package's prefix "package+".
149:0: error: "map-to-package-deps" doesn't start with package's prefix "package+".
152:0: error: "flatten" doesn't start with package's prefix "package+".
155:0: error: "package-transitive-closure" doesn't start with package's prefix "package+".
163:0: error: "rwd-map-filter" doesn't start with package's prefix "package+".
165:3: error: You should depend on (emacs "25.1") or the seq package if you need `seq-filter'.
168:0: error: "package-installed-with-deps" doesn't start with package's prefix "package+".
172:37: error: You should depend on (emacs "24.4") if you need `package-desc-name'.
178:0: error: "package-manifest-with-deps" doesn't start with package's prefix "package+".
188:0: error: "topo" doesn't start with package's prefix "package+".
191:0: error: "package-cleanup" doesn't start with package's prefix "package+".
195:19: error: You should depend on (emacs "25.1") or the seq package if you need `seq-filter'.
202:4: warning: Closing parens should not be wrapped onto new lines.
205:0: error: "package-manifest" doesn't start with package's prefix "package+".
242:5: error: You should depend on (emacs "27.1") if you need `package-quickstart-refresh'.
247:0: error: "package-view-manifest" doesn't start with package's prefix "package+".
256:0: error: `package+/topological-sort' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).

package+advice.el

byte-compile (using Emacs 27.1):

  • No issues!

checkdoc (using version 0.6.2):

Warning (emacs): 
package+advice.el:36: You should have a section marked ";;; Code:"
Warning (emacs): 
package+advice.el:56: The footer should be: (provide 'package+advice)\n;;; package+advice.el ends here
Warning (emacs): 
package+advice.el:37: Argument `oldfn' should appear (as OLDFN) in the doc string
Warning (emacs): 
package+advice.el:37: Lisp symbol `customize-save-variable' should appear in quotes
Warning (emacs): 
package+advice.el:44: Lisp symbol `package-selected-packages' should appear in quotes
Warning (emacs): 
package+advice.el:51: Lisp symbol `package-selected-packages' should appear in quotes

package-lint (using version 20210111.341):

2 issues found:
36:0: error: `package+/customize-save-variable/packages' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
53:3: error: You should depend on (emacs "24.4") or the nadvice package if you need `advice-remove'.

@riscy riscy merged commit e6af50f into melpa:master Jan 24, 2021
@riscy
Copy link
Member

riscy commented Jan 24, 2021

You may actually need to add a commit for the new recipe to get built. You can always monitor your build log at the bottom of your package's page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants