-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate previous label syncer #1
base: main
Are you sure you want to change the base?
Conversation
This maps what exists in https://github.com/meltano/meltano-labelsync/blob/main/labelsync.yml to the new format
labels.yaml
Outdated
- name: "Documentation" | ||
description: Improvements or additions to documentation | ||
color: "0075CA" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be consistent with our tag capitalization. I think all-lowercase is appropriate, maybe with a few exceptions.
- name: "Documentation" | |
description: Improvements or additions to documentation | |
color: "0075CA" | |
- name: "documentation" | |
description: Improvements or additions to documentation | |
color: "0075CA" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't suggest lowercasing the other uppercase letters in tags until we decide how we should handle this.
Co-authored-by: Will Da Silva <will@willdasilva.xyz>
Current batch that would be deleted:
|
@WillDaSilva I'm pretty happy with this first pass. There are definitely a few labels that we don't need, but I'd like to deal with those at a later date. For this PR, I pulled every label from the first time this job ran and either made sure it was in the file or added it to the "to delete" list. Once we get #2 sorted, I think we can merge this and go live. |
@WillDaSilva @tayloramurphy Is this in a good place to merge? I wanted to see if I could add a |
@edgarrmondragon I believe @tayloramurphy hit #10 when last trying to use this, and I haven't looked into the bug yet. With that bug resolved (and potentially also the rate limit bug), this should be good to go. |
This maps what exists in https://github.com/meltano/meltano-labelsync/blob/main/labelsync.yml to the new format