feat: apply annotations to determine if schedules should be enabled #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pnadolny13 - I think we want to wait for annotations feature (meltano/meltano#7215) to ship - but when that's done, can you help us test this using |
WillDaSilva
reviewed
Feb 14, 2023
| ) | ||
|
|
||
| globals()[base_id] = dag | ||
| logger.info(f"DAG created for schedule '{schedule['name']}', task='{run_args}'") | ||
| logger.info(f"DAG created for schedule '{schedule_name}', task='{run_args}'") | ||
|
|
||
|
|
||
| def create_dags(): |
There was a problem hiding this comment.
This runs meltano schedule list --format=json, which will not include annotation information. Currently, one has to ready the project files or manifest directly to get the annotations.
pnadolny13
reviewed
Feb 14, 2023
| ) | ||
| MELTANO_BIN = "meltano" | ||
|
|
||
|
|
||
| def _is_enabled(schedule_def: dict, environment_name: str) -> bool: | ||
| """Return true if the schedule should be enabled for the named environment.""" | ||
| airbyte_annotations: dict = schedule_def.get("annotations", {}).get("airbyte", {}) |
There was a problem hiding this comment.
@aaronsteers I think these were supposed to be airflow references instead of airbyte 😄 , right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
meltano.ymlat depth meltano#7215Resolves: