Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update tab-db2 plugin definition #1675

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Conversation

danielptv
Copy link
Contributor

Replace kind: password with sensitive: true and add newly introduced config options.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit a6da32a
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/65cfb229a365a50008c48c9f
😎 Deploy Preview https://deploy-preview-1675--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielptv
Copy link
Contributor Author

Looks like sensitive: true is not yet supported by the schema validation. Or have I missed something?

@pnadolny13
Copy link
Contributor

@danielptv thanks for the PR! sensitive is about to be added as part of #1667 (review). That should allow theses tests to pass.

@edgarrmondragon
Copy link
Collaborator

I don't think we should remove kind: password just yet :)

@danielptv
Copy link
Contributor Author

@edgarrmondragon should I keep both kind: password and sensitive: true or only kind: password?

@edgarrmondragon
Copy link
Collaborator

@danielptv I think keeping both is the most sensible. We could update Meltano to only log the warnings when the corresponding future replacement is not in place.

@danielptv
Copy link
Contributor Author

I have added back kind: password so both are now present.

@pnadolny13 pnadolny13 enabled auto-merge (squash) February 16, 2024 19:06
@pnadolny13 pnadolny13 merged commit c540e82 into meltano:main Feb 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants