Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid logging kind: {kind} is deprecated...` if the corresponding replacement is in place #8409

Closed
edgarrmondragon opened this issue Feb 16, 2024 · 2 comments · Fixed by #8486
Assignees

Comments

@edgarrmondragon
Copy link
Collaborator

This would make the migration smoother since the Hub could do a batch update that's backwards compatible. Older versions of Meltano (I think, yet to confirm) wouldn't crash if an unknown setting attribute such as sensitive is present.


@danielptv I think keeping both is the most sensible. We could update Meltano to only log the warnings when the corresponding future replacement is not in place.

Originally posted by @edgarrmondragon in meltano/hub#1675 (comment)

@edgarrmondragon
Copy link
Collaborator Author

Confirmed that Meltano 2.x doesn't complain about sensitive: true being present in the plugin definition.

Installing and preserving Meltano 2.x

$ pipx install 'meltano==2.*' --python python3.11 --suffix=@2                                                                                                                                                                                                        
  installed package meltano 2.20.0 (meltano@2), installed using Python 3.11.7
  These apps are now globally available
    - meltano@2
done! ✨ 🌟 ✨

$ pipx upgrade-all --skip meltano@2                                                                                                                                                                                                                                  
Versions did not change after running 'pipx upgrade' for each package 😴

$ meltano@2 --version                                                                                                                                                                                                                                                
meltano, version 2.20.0

@edgarrmondragon
Copy link
Collaborator Author

The batch update in question: meltano/hub#1696. Thanks to @pnadolny13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant