Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sensitive flag for password kind settings #1696

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Mar 1, 2024

The SDK metadata refresh automation has updated all password kind settings to include the sensitive flag but that doesnt consider non-SDK variants, this PR handles those. We started to get individual PRs like #1693 and #1692 to add the sensitive flag so clearly users are wanting the flag to be updated (presumably to get rid of warning logs) so I figured its good to get all plugins updated.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 9e5e162
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/65e1e106c4a7df0008c16213
😎 Deploy Preview https://deploy-preview-1696--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pnadolny13
Copy link
Contributor Author

@edgarrmondragon linting was failing because this touched a bunch of files that havent been touched in a while so the linting rules havent been invoked. The original changes are 3e0fa71 and the lint fixes are from #1697.

@edgarrmondragon
Copy link
Collaborator

We started to get individual PRs like #1693 and #1692 to add the sensitive flag so clearly users are wanting the flag to be updated (presumably to get rid of warning logs) so I figured its good to get all plugins updated.

Note that unfortunately this won't get rid of the warnings. I logged meltano/meltano#8409.

@edgarrmondragon linting was failing because this touched a bunch of files that havent been touched in a while so the linting rules havent been invoked. The original changes are 3e0fa71 and the lint fixes are from #1697.

woah, thanks for fixing those!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants