Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Cache Project.dotenv_env #8343

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 5, 2024

Closes #8342

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 2006e63
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/65a031a45e562d00085432f3

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1737840) 90.87% compared to head (2006e63) 90.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8343      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.01%     
==========================================
  Files         244      244              
  Lines       19023    19027       +4     
  Branches     2129     2129              
==========================================
+ Hits        17287    17294       +7     
+ Misses       1418     1415       -3     
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/perf/cache-project-dotenv-contents branch from 9ccb878 to 5660550 Compare January 9, 2024 17:16
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 9, 2024 20:32
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/perf/cache-project-dotenv-contents branch from 5660550 to c283c1e Compare January 11, 2024 01:01
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/perf/cache-project-dotenv-contents branch from c283c1e to 2006e63 Compare January 11, 2024 18:21
@edgarrmondragon edgarrmondragon added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit 2dea3bb Jan 11, 2024
50 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/perf/cache-project-dotenv-contents branch January 11, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

perf: Project's .env contents are evaluated too many times
2 participants