Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace row with record (non-breaking) #965

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Sep 14, 2022

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #965 (de557dc) into main (e24e94d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files          36       36           
  Lines        3555     3555           
  Branches      718      718           
=======================================
  Hits         2886     2886           
  Misses        492      492           
  Partials      177      177           
Impacted Files Coverage Δ
singer_sdk/streams/core.py 81.37% <ø> (ø)
singer_sdk/streams/rest.py 82.58% <ø> (ø)
singer_sdk/helpers/_typing.py 48.06% <100.00%> (ø)
singer_sdk/streams/sql.py 77.93% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronsteers aaronsteers merged commit e0fc993 into main Sep 14, 2022
@aaronsteers aaronsteers deleted the 242-replace-the-term-rows-with-records branch September 14, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the term rows with records
2 participants