Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: breaking rename changes: row->record (BREAKS) #966

Closed
wants to merge 3 commits into from

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Sep 14, 2022

This should not be merged until 1.0 release, or until we decide to make the breaking change.

Resolves:

Comes after:

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #966 (bfd529c) into main (e0fc993) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #966   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files          36       36           
  Lines        3555     3555           
  Branches      718      718           
=======================================
  Hits         2886     2886           
  Misses        492      492           
  Partials      177      177           
Impacted Files Coverage Δ
singer_sdk/streams/core.py 81.37% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from 242-replace-the-term-rows-with-records to main September 14, 2022 17:34
@edgarrmondragon edgarrmondragon deleted the 242-part2-breaking-rename-changes branch November 17, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants