Rearranging logic to deal with timing bugs. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a bug that could be reproduced by selecting typing something very quickly, selecting all of the text and then deleting it. A few moments later, the previous value would magically re-appear in the text box. This occured, because we were checking for minTermLength before clearing the timer. So the method was returning false b/c of query length before the timer could be cleared. Theoretically if the input text value has changed from prevValue, the previous query request is invalid, so it should be cleared. I moved this logic nearer to the top of the function and checked for the minTermLength further down, after the timer has already been cleared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a bug that could be reproduced by typing
something very quickly, selecting all of the text and then deleting it.
A few moments later, the previous value would magically re-appear in the
text box.
This occured, because we were checking for minTermLength before
clearing the timer. So the function was returning false b/c of query
length before the timer could be cleared.
Theoretically if the input text value has changed from prevValue, the
previous query request is invalid, so it should be cleared. I moved
this logic nearer to the top of the function and checked for the minTermLength
further down, after the timer has already been cleared.