Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assume role parameter passing #151

Merged
merged 4 commits into from Feb 2, 2021

Conversation

hhamalai
Copy link
Contributor

Fixes #150

Proposed Changes

  • Fix role ARN passing
  • Allow defining custom STS required when e.g., when Minio is used.

Description

With the changes defined role can be assumed with IAM (feature already merged but not released).

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

@kakkoyun
Copy link
Contributor

kakkoyun commented Feb 2, 2021

Hello @hhamalai, this looks on the right path, I can have a look after you fix the CI issues? Do you want to continue on this?

@hhamalai
Copy link
Contributor Author

hhamalai commented Feb 2, 2021

Thanks for reminding me!

I fixed the linter checks, can you probably point me how to react to that "generate" step error from CI.

Currently running a few builds utilizing this solution, thanks for creating it!

@kakkoyun
Copy link
Contributor

kakkoyun commented Feb 2, 2021

@hhamalai You just need to run

generate: ## Generate documentation, website and yaml files,
and commit the changes, if it looks good.

@kakkoyun kakkoyun enabled auto-merge (squash) February 2, 2021 09:39
@kakkoyun kakkoyun merged commit 40d8f10 into meltwater:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAM role assumption is not working with AWS IAM
2 participants