devtools: go: introduce go-cross #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poky change 9107d6ca144ac1f6169830dee25dae2dad775333 introduced support for
recipe specific sysroots.
The change follows some prior assumptions about the naming of cross compilation
toolchains. The naming is expected to match *-cross-* pattern. By convention,
`*-cross-` prefix is followed by ${TARGET_ARCH} (examples. binutils-cross-arm,
gcc-cross-arm). Since Go cross toolchain is named go-cross, when recipe specific
sysroot is built, the mechanism present in OE-core would not make the toochain
available to the recipe, hence any attempt to build Go code will fail.
On top of this BBCLASSEXTEND = "..cross.." is not a recommended solution for
toolchain like recipes. Upstream suggests sticking to convention of having a
`foo-cross` recipe and `inherit cross` inside.
The change introduces a recipe for go-cross that inherits `cross` class inside.
The recipe produces `go-cross-${TARGET_ARCH}` package. Recipes that `inherit go`
will automatically depend on `go-cross-${TARGET_ARCH}`
The fix should also be compatible with non-rss setups.
Signed-off-by: Maciej Borzecki <maciej.borzecki@rndity.com>
|
Thanks for taking the time to clean all of this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poky change 9107d6ca144ac1f6169830dee25dae2dad775333 introduced support for
recipe specific sysroots.
The change follows some prior assumptions about the naming of cross compilation
toolchains. The naming is expected to match -cross- pattern. By convention,
*-cross-prefix is followed by ${TARGET_ARCH} (examples. binutils-cross-arm,gcc-cross-arm). Since Go cross toolchain is named go-cross, when recipe specific
sysroot is built, the mechanism present in OE-core would not make the toochain
available to the recipe, hence any attempt to build Go code will fail.
On top of this BBCLASSEXTEND = "..cross.." is not a recommended solution for
toolchain like recipes. Upstream suggests sticking to convention of having a
foo-crossrecipe andinherit crossinside.The change introduces a recipe for go-cross that inherits
crossclass inside.The recipe produces
go-cross-${TARGET_ARCH}package. Recipes thatinherit gowill automatically depend on
go-cross-${TARGET_ARCH}The fix should also be compatible with non-rss setups.
@kacf @kraj @mem