Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak memory observation in the system #788

Open
wants to merge 6 commits into
base: memgraph-2-18
Choose a base branch
from

Conversation

Josipmrden
Copy link
Contributor

Description

New parameter has been added in the show storage info command that shows the peak memory in the system during the whole run

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page
  • New documentation page, release related

Related PRs and issues

PR this doc page is related to:
(especially necessary if the PR is related to a release)

Closes:
x

Checklist:

  • Check all content with Grammarly
  • Perform a self-review of my code
  • Make corresponding changes to the rest of the documentation (consult with the DX team)
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

@Josipmrden Josipmrden added the priority: low (improvements) An idea how the representation of knowledge on a certain page could be improved label May 22, 2024
@Josipmrden Josipmrden self-assigned this May 22, 2024
@Josipmrden Josipmrden requested a review from kgolubic as a code owner May 22, 2024 10:28
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 1:01pm

@kgolubic kgolubic changed the base branch from main to memgraph-2-18 May 28, 2024 14:11
@kgolubic kgolubic added the future release For one of the next versions label May 28, 2024
@kgolubic kgolubic added status: ready PR is ready for review Docs Ready - Pending Dev Merge Documentation reviewed and ready; awaiting corresponding dev merge. labels Jun 14, 2024
query execution happens. They are approximately of 56 bytes in size, but large-update transactions
can make the number of delta objects be huge - therefore resulting in Memgraph getting out of memory.

We have exposed the `peak_memory_res` variable in the `SHOW STORAGE INFO;` command, with which you

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain that res is an abbreviation for "resident"

can make the number of delta objects be huge - therefore resulting in Memgraph getting out of memory.

We have exposed the `peak_memory_res` variable in the `SHOW STORAGE INFO;` command, with which you
can monitor when the peak memory rises in the system. It will help you diagnose bottlenecks, and queries

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awkward. Too many comma. Try something like:
It will help you diagnose bottlenecks and high-memory queries which can be optimized.

Copy link

@hal-eisen-MG hal-eisen-MG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgolubic kgolubic added the status: ship it PR can be merged label Jun 17, 2024
Copy link
Collaborator

@kgolubic kgolubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK. Can be merged once the memgraph dev PR is merged.

@hal-eisen-MG
Copy link

Please link to the blocking PR in the other repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Ready - Pending Dev Merge Documentation reviewed and ready; awaiting corresponding dev merge. future release For one of the next versions priority: low (improvements) An idea how the representation of knowledge on a certain page could be improved status: ready PR is ready for review status: ship it PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants