Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add peak memory res to metrics and storage info #2048

Merged
merged 11 commits into from
Jun 30, 2024
Merged

Add peak memory res to metrics and storage info #2048

merged 11 commits into from
Jun 30, 2024

Conversation

Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented May 18, 2024 •
edited

Peak memory during the whole Memgraph run is recorded inside SHOW STORAGE INFO, and metrics server.

@Josipmrden Josipmrden added the feature feature label May 18, 2024
@Josipmrden Josipmrden self-assigned this May 18, 2024
@Josipmrden Josipmrden added this to the mg-v2.18.0 milestone May 22, 2024
@Josipmrden Josipmrden added the Docs needed Docs needed label May 22, 2024
@Josipmrden Josipmrden mentioned this pull request May 22, 2024
Merged
10 tasks
@Josipmrden Josipmrden added the CI -build=release -test=e2e Run release build and e2e tests on push label Jun 4, 2024
@Josipmrden Josipmrden enabled auto-merge June 4, 2024 10:53
@Josipmrden Josipmrden added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@Josipmrden
Copy link
Contributor Author

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Add peak memory to SHOW STORAGE INFO and metrics

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Peak memory usage has been added to SHOW STORAGE INFO and metrics
  • Link the documentation PR here
  • Tag someone from docs team in the comments @kgolubic

@Josipmrden Josipmrden added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Jun 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 30, 2024
@Josipmrden Josipmrden disabled auto-merge June 30, 2024 20:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 30, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Josipmrden Josipmrden added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 1579aae Jun 30, 2024
13 checks passed
@Josipmrden Josipmrden deleted the observe-peak-memory branch June 30, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ignition Ignition Ignition approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Assignees

@Josipmrden Josipmrden

Labels
CI -build=release -test=e2e Run release build and e2e tests on push Docs needed Docs needed feature feature
Projects
None yet
Milestone
mg-v2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Josipmrden @Ignition @antoniofilipovic