Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZonedDateTime data type to GQLAlchemy #312

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

matea16
Copy link
Contributor

@matea16 matea16 commented Jul 1, 2024

Description

Added Zoned date time data type that Memgraph supports to GQLAlchemy.

Pull request type

  • Feature

Related issues

Closes #300

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job however I think we can improve this

gqlalchemy/utilities.py Outdated Show resolved Hide resolved
gqlalchemy/models.py Outdated Show resolved Hide resolved
@katarinasupe
Copy link
Contributor

@matea16 merge the latest main for tests to pass.

Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I agree with Andi’s comments about avoiding unnecessary nesting

@matea16 matea16 requested a review from as51340 July 9, 2024 09:41
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but looks much better now

gqlalchemy/models.py Outdated Show resolved Hide resolved
@matea16 matea16 merged commit 8ad1670 into main Jul 9, 2024
5 checks passed
@katarinasupe katarinasupe added this to the v1.6.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CSVLocalFileSystemImporter can't load datetime from csv
4 participants