Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create memgraph-lab chart #18

Merged
merged 6 commits into from
May 6, 2024

Conversation

tewnut
Copy link
Contributor

@tewnut tewnut commented Apr 29, 2024

  • Supported templates: deployment, service, serviceaccount, ingress and hpa.
  • Tested with k8s 1.27, memgraph 2.16.

Copy link
Collaborator

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great, just two small comments. Good job 🚀

Later we can maybe introduce the Memgraph dependency, so the Memgraph-Lab becomes the both Memgraph and Lab in same deployment. OFC with the option to disable it at the start. But we will probably do that part since it involves upgrading the Memgraph chart.

Can you just update the README for available charts in this PR: https://github.com/memgraph/helm-charts?tab=readme-ov-file#available-charts?

charts/memgraph-lab/README.md Outdated Show resolved Hide resolved
@antejavor antejavor mentioned this pull request May 3, 2024
@antejavor antejavor added this to the v0.1.3. milestone May 3, 2024
@tewnut
Copy link
Contributor Author

tewnut commented May 4, 2024

Yes, certainly I will update the readme very soon.

Stacking all components into one chart is a popular design. At the same time keeping them separate (and highly independent of each other) has the beauty of its own. In my opinion, separating them is more beneficial, it may encourage community to further develop other UI (among other) components, which will boost adoption of Memgraph as a whole.

@tewnut tewnut requested a review from antejavor May 6, 2024 02:48
Copy link
Collaborator

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@antejavor antejavor merged commit 5ec18e9 into memgraph:release-0.1.3 May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants