Fix set_cover.greedy result type bug #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I try to use `set_cover.greedy` the following error is thrown: > Error: Query failed: set_cover.greedy: ValueError: Unable to insert field 'containing_set' with value: '<mgp.Vertex object at 0x7f83314cafd8>'; did you set the correct field type? It is because the function tries to set `Vertex` into a result type `List[Vertex]` for key `containing_set`. Along with the fix, `set_cover.greedy` has the same function call and response as `set_cover.cp_solve`.
tonilastre
added
type: bug
|
@Josipmrden Here is a reminder that this requires attention |
Josipmrden
approved these changes
Oct 14, 2021
|
The actual mistake that I made was in the last line
I assumed that this was a list. Since we're returning data in row-like fashion, it should actually be mgp.Vertex |
|
Closes #76 |
jmatak
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to use
set_cover.greedythe following error is thrown:It is because the function tries to set
Vertexinto a result typeList[Vertex]for keycontaining_set. Along with the fix,set_cover.greedynow has the same function call and response asset_cover.cp_solve.