Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < ] Bugfix: Path generation ignores edge's element_id #1108

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented Jul 26, 2023

Bolt v5 introduced element_id to Vertex and Edges.
When generating a Path, the edge's element_id got ignored and defaulted to "".

closes #1100

@andrejtonev andrejtonev changed the title Bugfix: Path generation ignores edge's element_id [master < ] Bugfix: Path generation ignores edge's element_id Jul 26, 2023
@andrejtonev andrejtonev self-assigned this Jul 26, 2023
@andrejtonev andrejtonev added bug bug bolt An issues or feature related to bolt protocol. labels Jul 26, 2023
@andrejtonev andrejtonev added this to the mg-v2.10.0 milestone Jul 26, 2023
@andrejtonev andrejtonev marked this pull request as draft July 26, 2023 12:55
@andrejtonev andrejtonev marked this pull request as ready for review July 26, 2023 12:55
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 💪

@gitbuda gitbuda merged commit 110ca39 into master Jul 29, 2023
6 checks passed
@gitbuda gitbuda deleted the MG-boltv5-path-bugfix branch July 29, 2023 13:51
@andrejtonev
Copy link
Contributor Author

@vpavicic
I think we already discussed this fix. I'll write it here as well, just for consistency.

Bolt v5 introduced element_id. This variable was added to structures: Node, Relationship and UnboundRelationship.
Issue was that during Path generation the element_id was ignored and the resulting list of UnboundRelationships would all have element_id set to "".

@vpavicic
Copy link
Contributor

vpavicic commented Aug 2, 2023

Yes, we discussed it already :) thnx anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bolt An issues or feature related to bolt protocol. bug bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Query not working anymore with Memgraph 2.9
4 participants