[master < T0766-MG] Fix ORDER BY and temporal types #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio2368
requested review from
antaljanosbenjamin,
gitbuda,
jbajic and
kostasrim
as code owners
jbajic
approved these changes
Nov 15, 2021
|
Maybe one more question: do we want to allow the comparison between date and datetime? witthout this, it feels like a bit incomplete (a date can be considered as a datetime with the time part zerod out). |
If we do that we should allow the same thing in the comparison operator for TypedValues which we don't for now. |
antaljanosbenjamin
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[master < Task] PR