-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T517] On delete triggers invalid edge reference #717
[master < T517] On delete triggers invalid edge reference #717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked the tests, because
Two more questions from my side:
|
….com:memgraph/memgraph into T517-FL-invalid-edge-accessor-edge-reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer your questions:
Is this the correct logic if (delta->vertex_edge.edge != edge_) return !deleted;
No, but as I see you already fixed it. Accessing the fields of a delta without knowing what type of delta is that is bad (in most of the cases you can end up with undefined behavior).
Is test_create_on_delete_explicit_transaction valid for all three isolation levels?
I would say it should be okay. The isolation levels are important when you work with multiple transaction simultaneously. In the test you don't have multiple transactions, so I would say the isolation levels should have no affect on the test. However there is always a possibility that I missed something or just plain wrong, so if you noticed something strange, feel free to bring it up, it might lead to interesting conversation on top of helping you.
There are still some comments left here. Can you resolve them all + uncomment the e2e test config? |
[master < Epic] PR
[master < Task] PR