[master < T517] On delete triggers invalid edge reference

[as51340]

[master < Epic] PR

• Check, and update documentation if necessary
• Update changelog
• Write E2E tests
• Compare the benchmarking results between the master branch and the Epic branch
• Provide the full content or a guide for the final git message

[master < Task] PR

• Check, and update documentation if necessary
• Update changelog
• Provide the full content or a guide for the final git message

[antaljanosbenjamin]

I haven't checked the tests, because

[as51340]

Two more questions from my side:

1. Is this the correct logic if (delta->vertex_edge.edge != edge_) return !deleted;
2. Is test_create_on_delete_explicit_transaction valid for all three isolation levels? Workflow:

• create trigger
• create and delete edge in the explicit transaction

[antaljanosbenjamin]

To answer your questions:

Is this the correct logic if (delta->vertex_edge.edge != edge_) return !deleted;

No, but as I see you already fixed it. Accessing the fields of a delta without knowing what type of delta is that is bad (in most of the cases you can end up with undefined behavior).

Is test_create_on_delete_explicit_transaction valid for all three isolation levels?

I would say it should be okay. The isolation levels are important when you work with multiple transaction simultaneously. In the test you don't have multiple transactions, so I would say the isolation levels should have no affect on the test. However there is always a possibility that I missed something or just plain wrong, so if you noticed something strange, feel free to bring it up, it might lead to interesting conversation on top of helping you.

[gitbuda]

There are still some comments left here. Can you resolve them all + uncomment the e2e test config?