[master < T1246] Add index statistics for better query planning #812

Josipmrden · 2023-02-28T12:06:27Z

The PR concerns providing more information to indexes which then can be used optimally in query planning, to make better decisions when to use one index over the other. It is only scoped to label property indexes.

antoniofilipovic

I need to take look at tests still, let me know when you check comments, we can discuss what makes sense to change.

src/query/frontend/ast/cypher_main_visitor.cpp

src/query/plan/rewrite/index_lookup.hpp

src/query/interpreter.cpp

src/utils/math.hpp

src/query/plan/rewrite/index_lookup.hpp

src/query/interpreter.cpp

src/utils/math.hpp

src/storage/v2/indices.cpp

src/storage/v2/storage.hpp

src/query/plan/rewrite/index_lookup.hpp

src/query/interpreter.cpp

src/query/CMakeLists.txt

src/query/interpreter.cpp

Josipmrden

Needs change but I'm not in the list of reviewers

src/query/frontend/ast/ast.lcp

src/query/frontend/opencypher/grammar/MemgraphCypher.g4

src/query/frontend/ast/cypher_main_visitor.cpp

src/query/plan/rewrite/index_lookup.hpp

src/storage/v2/indices.hpp

src/storage/v2/indices.cpp

src/query/interpreter.cpp

tests/e2e/analyze_graph/optimize_indexes.py

src/query/plan/rewrite/index_lookup.hpp

src/query/interpreter.cpp

tests/e2e/analyze_graph/optimize_indexes.py

src/query/interpreter.cpp

src/query/interpreter.hpp

src/utils/math.hpp

antoniofilipovic

There are some commented things you left, remove that and it should be ready to ship it

Add index statistics for better query planning

d172682

Josipmrden added this to the v2.7.0 milestone Feb 28, 2023

Josipmrden requested review from gitbuda, antaljanosbenjamin, brunos252, antepusic, as51340 and antoniofilipovic February 28, 2023 12:06

Josipmrden self-assigned this Feb 28, 2023

Josipmrden marked this pull request as draft February 28, 2023 12:06

Josipmrden changed the title ~~Add index statistics for better query planning~~ [E217 < T1246] Add index statistics for better query planning Mar 7, 2023

Josipmrden and others added 4 commits March 7, 2023 11:52

Add e2e tests for graph analysis

415a195

Lexer impl

27b35ef

Simple connection interpr

997a5b2

Chi-squared stats connected

e4e7929

as51340 self-assigned this Mar 14, 2023

as51340 added 4 commits March 14, 2023 14:51

Chi-squared est and delete stat

a74bb8d

Tests for graph analysis

4c7822c

Clean code

3638f97

Fixed tests

91bb03a

as51340 removed request for gitbuda, antaljanosbenjamin, brunos252, antepusic and as51340 March 16, 2023 13:34

as51340 marked this pull request as ready for review March 16, 2023 13:35

as51340 requested a review from jbajic March 16, 2023 13:38

Merge branch 'master' into T1246-MG-index-optimization-graph-analyzer

bf209d1

as51340 changed the base branch from E217-index-optimization-graph-analyzer to master March 17, 2023 10:39

as51340 changed the title ~~[E217 < T1246] Add index statistics for better query planning~~ [master < T1246] Add index statistics for better query planning Mar 17, 2023

Clang-tidy fix

7da53c6

antoniofilipovic suggested changes Mar 20, 2023

View reviewed changes

as51340 mentioned this pull request Mar 21, 2023

[master < T607-FL] Index optimization memgraph/docs#785

Merged

6 tasks

as51340 added 2 commits March 21, 2023 12:20

Cleaning checks and storage access

08e4be6

Clean Comp

4431a80

jbajic reviewed Mar 22, 2023

View reviewed changes

Josipmrden removed their assignment Mar 22, 2023

Josipmrden commented Mar 22, 2023

View reviewed changes

Code clean

2f90429