Remove noexcept from functions that may throw #819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Memgraph crashing when a user’s query procedure attempts to construct a
LocalDateTime
object with invalid parametersA C++ API
LocalDateTime
object is built upon amemgraph::utils::LocalDateTime
object, which has a constructor that’s a) noexcept b) constructs amemgraph::utils::Date
member, which may throw an exceptionThis error has been fixed together with other
LocalDateTime
constructors that were marked as noexcept but might throw an exception[master < Task] PR
To keep docs changelog up to date, one more thing to do: