Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noexcept from functions that may throw #819

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

antepusic
Copy link
Contributor

@antepusic antepusic commented Mar 6, 2023

This PR fixes Memgraph crashing when a user’s query procedure attempts to construct a LocalDateTime object with invalid parameters
A C++ API LocalDateTime object is built upon a memgraph::utils::LocalDateTime object, which has a constructor that’s a) noexcept b) constructs a memgraph::utils::Date member, which may throw an exception
This error has been fixed together with other LocalDateTime constructors that were marked as noexcept but might throw an exception
[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

Fix Memgraph crashing when constructing mgp::LocalDateTime objects with invalid parameters

To keep docs changelog up to date, one more thing to do:

  • Write a release note here

Constructing LocalDateTime objects with invalid parameters doesn’t crash Memgraph anymore, but throws an informative exception.

  • Tag someone from docs team in the comments

@antepusic antepusic added bug bug Ready for review PR is ready for review labels Mar 6, 2023
@antepusic antepusic self-assigned this Mar 6, 2023
@antepusic
Copy link
Contributor Author

@vpavicic The release note is in the initial comment

@antoniofilipovic
Copy link
Collaborator

@antepusic write a release note here. @vpavicic

@Josipmrden
Copy link
Contributor

@antepusic @antoniofilipovic can this go in the release?

@antoniofilipovic
Copy link
Collaborator

@Josipmrden yes, I will merge this.

@antoniofilipovic antoniofilipovic merged commit 173f543 into master Mar 6, 2023
@antoniofilipovic antoniofilipovic deleted the T603-FL-microchip-crash branch March 6, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug Ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants