-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < ] Parallelize recovery #868
Conversation
Here some measurements from my laptop and from wolverine. The important intervals:
My laptopOriginal version
8 threads
4 threads
wolverineLOAD CSV FROM "/home/mg/benjo/generated_text_nodes_big.csv" NO HEADER AS row Original version
16 threads
10 threads
8 threads
4 threads
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to check tests still, will do that tomorrow morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at tests, all seems good to me
@antoniofilipovic I think first #882 has to be merged here (before we merge this to master)? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🚀
This reverts commit 7dec982.
* Parallelize edge recovery * Load vertex labels and properties parallel * Add parallel connectivity loading * Add batches information to snapshot * Introduce `items_per_batch` and `recovery_thread_count` flags * Make possible to load snapshots with old version * Add vertex batches to `RecoveryInfo` * Extend durability integration tests with v15 test cases * Add `std::vector` based `InitProperties` * Use `InitProperties` in snapshot loading
I force-pushed master back and then did the merge manually on my machine, because I accidentally left the |
[master < Epic] PR
[master < Task] PR
To keep docs changelog up to date, one more thing to do: