[master] < MG-parallelize-index-creation #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the RecoverIndicesAndConstraints function it is now possible to execute the index recration after a crash in a multithreaded fashion.
The issue was caused by the difference when trying to recover from snapshots and WAL files. The parallelized version of index creation is based on RecoveryInfo::vertex_batches which is always empty in the case of recovering from WAL files. In that case the sequential index creation will be used.
gvolfing
requested review from
antoniofilipovic,
Josipmrden and
antaljanosbenjamin
antaljanosbenjamin
suggested changes
Apr 19, 2023
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
|
@gvolfing I think this should be disabled by default (an opinion). Another thing, I think the |
8 tasks
6 tasks
|
… during parallel index creation.
antoniofilipovic
approved these changes
Apr 25, 2023
antaljanosbenjamin
approved these changes
Apr 25, 2023
antaljanosbenjamin
force-pushed
the
master
branch
from
7dec982
to
64fd281
Compare
|
@antoniofilipovic & @gvolfing I have a release note in the docs PR, but the PR is still a draft, so is there more info coming? Seems like the index page should be updated as well Maybe this has nothing to do with creating indexes outside of the recovery process? Can I use this for regular index creation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[master < MG-parallelize-index-creation] PR