Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master < E219] Map projection #892

Merged
merged 5 commits into from
May 16, 2023
Merged

[master < E219] Map projection #892

merged 5 commits into from
May 16, 2023

Conversation

antepusic
Copy link
Contributor

@antepusic antepusic commented Apr 23, 2023 •
edited

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

Add the map projection feature

To keep docs changelog up to date, one more thing to do:

  • Write a release note here
  • Tag someone from docs team in the comments

Release note:

It’s now possible to use the map projection syntax to create maps. Map projections are convenient for building maps based on existing values and they are used by data access tools like GraphQL and Spring Data.

@antepusic antepusic added this to the mg-v2.8.0 milestone Apr 23, 2023
@antepusic antepusic self-assigned this Apr 23, 2023
@antepusic antepusic marked this pull request as draft April 23, 2023 10:24
@antepusic antepusic linked an issue Apr 23, 2023 that may be closed by this pull request
Support for map projections #841
Closed
@antepusic antepusic marked this pull request as ready for review April 23, 2023 17:06
@antepusic antepusic marked this pull request as draft April 23, 2023 17:08
@antepusic antepusic changed the title Map projection [master < E219] Map projection Apr 24, 2023
@antepusic antepusic mentioned this pull request May 16, 2023
Merged
6 tasks
@antepusic antepusic added Ready for review PR is ready for review and removed Status - In Progress labels May 16, 2023
This was referenced May 16, 2023
Merged
Merged
Merged
@antepusic antepusic marked this pull request as ready for review May 16, 2023 08:05
@gitbuda gitbuda mentioned this pull request May 16, 2023
Closed
1 task
Josipmrden
Josipmrden reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small number of comments

src/query/frontend/ast/ast.hpp Show resolved Hide resolved
src/query/frontend/ast/pretty_print.cpp Show resolved Hide resolved
src/query/frontend/opencypher/grammar/Cypher.g4 Show resolved Hide resolved
src/query/interpret/eval.hpp Show resolved Hide resolved
tests/benchmark/query/eval.cpp Show resolved Hide resolved
@Josipmrden Josipmrden self-requested a review May 16, 2023 14:20
@antepusic
Copy link
Contributor Author

@kgolubic I’ve opened PR #888 on the docs side concerning this PR

@antoniofilipovic antoniofilipovic merged commit 0d9bd74 into master May 16, 2023
@antoniofilipovic antoniofilipovic deleted the E219-MG-map-projection branch May 16, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josipmrden Josipmrden Josipmrden approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

@brunos252 brunos252 Awaiting requested review from brunos252

Assignees

@antepusic antepusic

Labels
community community epic feature feature Ready for review PR is ready for review
Projects
No open projects
memgraph-v2 issues
Status: ✅ Done
Milestone
mg-v2.8.0
Development

Successfully merging this pull request may close these issues.

Support for map projections
3 participants
@antepusic @Josipmrden @antoniofilipovic