Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable and fix #![deny(clippy::undocumented_unsafe_blocks)] and #![deny(clippy::missing_safety_doc)] #1270

Open
kkysen opened this issue Jun 28, 2024 · 0 comments
Open

Enable and fix #![deny(clippy::undocumented_unsafe_blocks)] and #![deny(clippy::missing_safety_doc)] #1270

kkysen opened this issue Jun 28, 2024 · 0 comments
Assignees
@kkysen
Labels
safety/correctness

Comments

@kkysen
Copy link
Collaborator

kkysen commented Jun 28, 2024

No description provided.

@kkysen kkysen self-assigned this Jul 5, 2024
@kkysen kkysen mentioned this issue Jul 10, 2024
Open
@kkysen kkysen changed the title Enable and fix #[deny(clippy::undocumented_unsafe_blocks)] and #[deny(clippy::missing_safety_doc)] Enable and fix #![deny(clippy::undocumented_unsafe_blocks)] and #![deny(clippy::missing_safety_doc)] Jul 10, 2024
This was referenced Jul 10, 2024
Merged
Merged
kkysen added a commit that referenced this issue Jul 11, 2024
@kkysen
#![deny(clippy::undocumented_unsafe_blocks)]: Add and fix existing …
c34d308 
…safety comments (#1305)

* Part of #1270.

This adds `#![deny(clippy::undocumented_unsafe_blocks)]` to the
`librav1d` crate. Since we don't yet run `clippy` in CI, this doesn't do
anything yet, but that's good, since we can turn that on once we fix all
of the errors. This PR only turns on the lint and fixes the existing
safety comments into ones that the lint recognizes.
kkysen added a commit that referenced this issue Jul 11, 2024
@kkysen
#![deny(clippy::missing_safety_doc)]: Add (already fixed) (#1306)
cf11e47 
* Fixes `#![deny(clippy::missing_safety_doc)]` of #1270.

This already passes without errors, unlike
`#![deny(clippy::undocumented_unsafe_blocks)]` in #1305.
@kkysen kkysen mentioned this issue Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkysen kkysen

Labels
safety/correctness
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkysen