Moving graphs and mining dashboard to a lazy loaded module #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softsimon
force-pushed
the
simon/lazy-loaded-modules
branch
from
b37ea8c
to
e6c4b87
Compare
That's because you need to pre-load the lazy-loaded bundles asynchronously in the background so they're already pre-cached in RAM by the time you need them to render the next page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to separate the EChart and Graphs component to a separate lazy loaded module.
So if the user directly navigates to
/tx//block//address/and other pages that doesn't contain a graph, that module won't be loaded and we should increase the initial loading time a lot.
Upon loading
//mining/graphs/tvThe lazy loaded bundle containing the graphs will be loaded.
The uncompressed main bundle is down from 2.3 MB to 1 MB.
To test this we need to make sure that nothing broke. That mainnet, testnet, Liquid and Bisq still works. Also make sure we didn't introduce any other annoyance or flicker. For example opening a block and clicking on a Mempool Block will now cause a small delay because the graph-bundle is required to display a mempool block.