Bisq dashboard #381
Merged
Bisq dashboard #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiz
requested changes
Mar 8, 2021
There was a problem hiding this comment.
Looks great. Here's probably a good list of things to work on for MVP:
- Add new "master page" and entrypoint for bisq.markets, add autocomplete pull-down in the top
- Add new Bisq Markets logo from Pedro
- Add new aggregated graph of all market volume on front page above table to match your mockup
- Add table of "recent trades" on each market
- Add table of "recent trades" to bottom of top page
- Add volume to graphs
- Change market names from "Bitcoin" to "USD" or "EUR" etc.
- Sort table by number of trades as default sort option, make other columns sortable
- Fix precision on BSQ graph to 8 decimal places
- Add frontend configuration variable for OFFICIAL_BISQ_MARKETS, and if not enabled then hide non-Bitcoin markets :)
* simon/cpfp-frontend: (46 commits) Bugfix: Don't extend already extended transactions to not override the firstSeen property. fixes #390 Shuffle mempool transactions before saving disk cache. (#398) Adding missing return after expressjs response. CPFP support (#395) Round sat/vB in fee rating tooltip. fixes #364 Add the GNU AGPLv3 logo to About page Update package.json license tags Add recommended fee percentile config (#394) Fix typo in README (#392) Fix icon for Specter Wallet on About page Add link to Specter Wallet on our About page Add link to WARden Portfolio app as Community Integration on About page Delete MIT+CC license from Terms of Service, add AGPLv3 to About page Change mempool project license to GNU Affero General Public License v3 Lower volume for sound effects (#385) Improve grammar, layout, and formatting of Terms of Service page Display all Project Contributors on About page using GitHub API (#382) Modify nginx.conf to cache HTML for 10m and static resources for 1h Proxy /api/v1/contributors from mempool.space, also fix HTTP headers Add link to Bisq's GitHub repo on About page ...
wiz
requested changes
Mar 22, 2021
There was a problem hiding this comment.
Looking pretty fricken cool. Here are some more requested changes:
- If
OFFICIAL_BISQ_MARKETSthen also change favicon to Bisq cat logo - Add loading spinner animation on front page graph
- Add loading spinner animation when changing graph timespan
- Optimize graph loading time/speed
- Mouseover legend is flipped for volume and number of trades is flipped
- On home page graph, make BTC volume less prominent
- On individual market graphs, make BTC volume less prominent, remove color from bars
- Make unique URLs for graph timespans
- Hide markets with 0 trades in past 7 days, but allow them to be found in a searchable auto-complete pull-down box in top nav bar
- Add table of "recent trades" to bottom of top page
- Sort table by number of trades as default sort option, make other columns sortable
# Conflicts: # frontend/package-lock.json # frontend/package.json
fix infinite scrolling by not using body as the container
# Conflicts: # frontend/package-lock.json # frontend/src/app/components/master-page/master-page.component.html
wiz
requested changes
Apr 23, 2021
There was a problem hiding this comment.
Looks great! Let's move the remaining items to a separate PR later, and there's just one bug I found we should fix before merging, which is the lack of empty candles in illiquid markets. For example, on the JPY market there are no trades between 2017 - 2019 but there are no empty candles for this timeframe, even on a 1D chart.
|
Also, please filter Shitcoins from the Trade History on the top page when not official bisq.markets |
wiz
requested changes
Apr 24, 2021
There was a problem hiding this comment.
Almost ready to merge, just a few more quick fixes:
- Round off all BTC amounts to 0.001 precision
- Make the 3rd column on top dashboard "Amount in BTC", and have all BTC values swapped in that column
- Swap the 3rd and 4th columns on market pages "latest trades" table so "amount in BTC" is the 3rd column
- Change top string on bisq dashboard from "Trading volume" to "Bisq Trading Volume"
- Change string on non-official bisq dashboard for "Markets" to "Bitcoin Markets"
- Add i18n tags on all strings
- Make table columns and chart adaptive for mobile devices
# Conflicts: # frontend/src/locale/messages.xlf
wiz
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.