Refactor websocket address tracking #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution to The Mempool Open Source Project. We require all contributors to agree to our Contributor License Agreement and don't seem to have one for you on file. Please see the instructions in CONTRIBUTING.md to proceed with this pull request. |
softsimon
reviewed
Aug 6, 2023
softsimon
approved these changes
Aug 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how we handle the
track-addresswebsocket subscription in the backend to reduce code duplication and scale better for many simultaneous subscriptions.Instead of searching the full list of transactions separately for every subscribed client, we build a mini address index cache once up front, from which we can look up tracked addresses in the client update loop in ~constant time.
Building the cache adds a small constant overhead to the
$handleMempoolChangeandhandleNewBlockfunctions, but the fast lookups maintain performance much better when there are many open address subscriptions.