Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs loading indicators update #5099

Merged
merged 2 commits into from
May 25, 2024
Merged

Graphs loading indicators update #5099

merged 2 commits into from
May 25, 2024

Conversation

natsoni
Copy link
Contributor

@natsoni natsoni commented May 24, 2024

Fixes #5083

This PR unifies the UX in graphs by greying out the chart during data loading:

Screenshot 2024-05-24 at 13 58 51 Screenshot 2024-05-24 at 14 04 55

etc.

@natsoni natsoni requested a review from softsimon May 24, 2024 12:06
@cla-bot cla-bot bot added the cla-signed label May 24, 2024
@natsoni
Copy link
Contributor Author

natsoni commented May 24, 2024

bd5abf6 re-enables timespan controls when data is loading. It was disabled to fix an issue (#3094 (comment)), but I can't reproduce it.

Also adds a missing space in incoming txs graph tooltip:
Screenshot 2024-05-24 at 17 11 13

Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [bd5abf6]

@softsimon softsimon merged commit 46b5b26 into master May 25, 2024
13 checks passed
@softsimon softsimon deleted the natsoni/graphs-cleanup branch May 25, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphs page loading spinner position
2 participants