-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mining pools to search results #5117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pool search works great.
But the change of the order should probably have been in a separate PR, because there is one issue with it. The search result isn't selecting the top result, so pasting a Lightning nod pubkey and press enter still takes you to an address page. Is it possible to move the search highlight index to the top without any issues in this case? Either that or move it out from this PR for now.
![Screenshot 2024-05-31 at 12 54 55](https://private-user-images.githubusercontent.com/8561090/335460412-53a64c1a-25dd-458a-a3b9-e5a82824a943.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MDMwNTIsIm5iZiI6MTcyMTUwMjc1MiwicGF0aCI6Ii84NTYxMDkwLzMzNTQ2MDQxMi01M2E2NGMxYS0yNWRkLTQ1OGEtYTNiOS1lNWE4MjgyNGE5NDMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjBUMTkxMjMyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmIxNjUwMmI4MGQyZDJlNGJkYmNkZjdiMDhiZTUyMzViOGMwZmJjMjNiMjI0NjIwZThmZjZmZDQyNTE2ODQwZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.7DhKRQArauNcdjV0zLmaTPBUaI8H8LerqsSyQ9N56fg)
This reverts commit 00838ea.
Reverted the changes made to the results order, will work on that in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ACK @ [f3bd50d]
This PR adds mining pools support to the search bar. Active pools (which mined a block in the last year) are shown first.
I also updated the order of the results displayed to fix #4993. Now, if the search is exact match with a public key, the address result is displayed at the end, and the other networks results are hiddenThere are other issues I will fix in separate PRs to simplify the review for this one.
Screen.Recording.2024-05-30.at.15.22.40.mov
Screen.Recording.2024-05-30.at.15.40.16.mov