Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API docummentation. #544

Merged
merged 17 commits into from Jun 6, 2021
Merged

New API docummentation. #544

merged 17 commits into from Jun 6, 2021

Conversation

MiguelMedeiros
Copy link
Contributor

New API documentation.

@MiguelMedeiros
Copy link
Contributor Author

Fix #461

@MiguelMedeiros MiguelMedeiros marked this pull request as ready for review May 31, 2021 18:28
@wiz
Copy link
Member

wiz commented Jun 2, 2021

Great work, I like the syntax highlighting but I don't think it's worth adding a new npm dep for that - if we want to do syntax highlighting probably best to just make our own CSS and not add a new dependency

@MiguelMedeiros
Copy link
Contributor Author

Great work, I like the syntax highlighting but I don't think it's worth adding a new npm dep for that - if we want to do syntax highlighting probably best to just make our own CSS and not add a new dependency

Ok, done!

  • Removed the highlight.js dependency.
  • Made our own styles for code-template-component.

Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve 👍

@softsimon softsimon merged commit 353b0e8 into mempool:master Jun 6, 2021
@MiguelMedeiros MiguelMedeiros deleted the api-docs branch July 18, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants