Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bisq support #92

Merged
merged 33 commits into from Jul 19, 2020
Merged

Bisq support #92

merged 33 commits into from Jul 19, 2020

Conversation

softsimon
Copy link
Member

@softsimon softsimon commented Jul 14, 2020 •
edited by wiz

This PR adds a new optional module that supports exploring the Bisq DAO as per bisq-network/projects#37

softsimon and others added 26 commits July 3, 2020 23:45
@softsimon
WIP: Bisq DAO support. Transactions list and details.
c21dad8
@softsimon
merge from master
4ff9663
@softsimon
Auto reload bisq dump file.
8c23eae
@softsimon
Bisq explorer is now a separate module.
60e1b9a
@softsimon
Bisq module separation.
db2e293 
Transaction view.
Block view.
Blocks list.
@softsimon
Address index and api.
432fb9c 
Address view.
@softsimon
Display network logo in the top bar.
87abfc3 
Allow search for block height.
Hide empty bisq blocks.
@softsimon
Bisq statistics page.
b7376fb
@softsimon
Bisq stats page.
ca0cf23 
BSQ prices.
@softsimon
Show fiat value of totalRecieved for addresses.
3008f99 
Rename fee to fee burnt.
@softsimon
Rearange network dropdown.
3333b76 
API for Bisq block height tip.
Loading indicators on transactions/blocks view.
Total sent now correctly display burnt on Pay trade fee txs.
@softsimon
Corrected Liquid logo.
e4a65bd
@softsimon
Watch dir instead of json file.
40f7eaf 
Adding divider to network dropdown.
@softsimon
Remove filename check for fs.watch
40afa7a
@softsimon
Network menu design updates.
87e56e2
@softsimon
Fix responsiveness.
c5759be
@softsimon
If bisq tx not found, check for regular tx and redirect to /tx/
d3d3fd0
@softsimon
Handle errors in block component.
ad3c295
@softsimon
Fixed bisq transaction id.
74e9eca
@softsimon
Table design and responsiveness updates.
3ff1957
@softsimon
Adding Bisq API to About page.
d22e4a0 
Watching partent bisq dump folder.
@softsimon
Handle confirm transactions not present in the bisq database.
425f415
@softsimon
Watch for bisq dump recursively.
3df36cd
@softsimon
Adding multiple fs.watch-ers to handle Bisq restarts.
66c565a
@softsimon
Send correct content-types.
5198c3a
@wiz
Add proxy_pass with rewrite for /bisq/api into nginx.conf
4e6ba18
@Emzy
Copy link
Member

Emzy commented Jul 18, 2020

Tested ACK
I have installed this pr on htps://mempool.emzy.de looks good to me.
Compared some BSQ transactions, all look the same.
Did no code review.

@wiz
Copy link
Member

wiz commented Jul 18, 2020 •
edited by softsimon

@softsimon Thanks for your hard work, the new Bisq explorer is amazing!

AFAIK the only remaining show stopper issues are:

  • Fix pagination issue preventing scroll back to last page, i.e. /bisq, /bisq/blocks, etc.
  • Fix API docs on About page, i.e. /api/v1/bisq -> /bisq/api
  • Fix mobile layout so /bisq fits and it does not scroll horizontally
  • Add missing Layer 1 data to Bisq TX page, i.e. mining fees, etc.

wiz
wiz approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@wiz wiz merged commit 222b7b9 into master Jul 19, 2020
@wiz wiz mentioned this pull request Jul 19, 2020
Closed
4 tasks
@softsimon softsimon mentioned this pull request Jul 20, 2020
Closed
@wiz wiz deleted the bisq branch July 20, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@softsimon @Emzy @wiz