Swapping handles order is prevented #532
Conversation
|
@pulyaevskiy can you please review? |
| // if (newSelection.baseOffset >= newSelection.extentOffset) | ||
| // return; // don't allow order swapping. | ||
| if (newSelection.baseOffset >= newSelection.extentOffset) | ||
| return; // don't allow order swapping. |
There was a problem hiding this comment.
I have one question here. It looks like on iOS even though swapping is allowed it'll also result in actual handles swap.
Meaning if extent < base then we actually flip the values as well so that base becomes the lower value.
On Android, I believe, handles don't swap (but I might be wrong). Have you tested it?
There was a problem hiding this comment.
I tested Flutter's TextField behavior on both iOS & Android. They behave the same => now swapping
But you are right, on iOS native text, selection handles do swap.
Should we mimic Flutter's TextField?
otherwise we need to define the desired behavior on each supported platforms
There was a problem hiding this comment.
Gotcha, I think we should stay consistent with what Flutter does so that we get the same behavior within a Flutter app as a whole.
Thanks for the details!
Closes issue #531