Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question here. It looks like on iOS even though swapping is allowed it'll also result in actual handles swap.
Meaning if extent < base then we actually flip the values as well so that base becomes the lower value.
On Android, I believe, handles don't swap (but I might be wrong). Have you tested it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested Flutter's TextField behavior on both iOS & Android. They behave the same => now swapping
But you are right, on iOS native text, selection handles do swap.
Should we mimic Flutter's TextField?
otherwise we need to define the desired behavior on each supported platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, I think we should stay consistent with what Flutter does so that we get the same behavior within a Flutter app as a whole.
Thanks for the details!