Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEN-4395: Bump version to 2021-01-11 #1367

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

oleorhagen
Copy link
Contributor

Changelog: None
Signed-off-by: Ole Petter ole.orhagen@northern.tech

Copy link
Contributor

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this one, I think we should wait for the release.

You might think that updating only master is innocent, but there is a good chance that we merge to hosted branch and then they become defacto released.

At least I can say that in the past we only update these links during a release. I think this time we have made it in advance (because we knew there was an issue) but still we should wait for the docs until the release.

@oleorhagen
Copy link
Contributor Author

So should I, as mentioned in the other PR:

  • Do a publish job of the other client versions with the new image, but leave the docs untouched
  • And leave the ticket in the Merged state?

@lluiscampos
Copy link
Contributor

So should I, as mentioned in the other PR:

* Do a publish job of the other client versions with the new image, but leave the docs untouched

* And leave the  ticket in the Merged state?

Ticket is done, as the code has landed in its respective branches. And you don't need to publish the new images: release is not part of every single task, right?

@oleorhagen
Copy link
Contributor Author

Holding off for the release

@oleorhagen oleorhagen force-pushed the MEN-4395 branch 2 times, most recently from f604460 to 9631975 Compare April 19, 2021 05:58
Changelog: None
Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants