Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEN-2048: Fix MENDER_GRUB_STORAGE_DEVICE variable not being respected. #585

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

kacf
Copy link
Member

@kacf kacf commented Aug 20, 2018

Changelog: Title

Signed-off-by: Kristian Amlie kristian.amlie@northern.tech

Changelog: Title

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
@kacf kacf requested a review from estenberg August 20, 2018 13:42
@kacf
Copy link
Member Author

kacf commented Aug 20, 2018

Documentation will come separately through MEN-1992.

@estenberg
Copy link
Contributor

Thanks! I am trying to test but get some (seemingly unrelated) errors of fetching linux-intel. Hope it is intermittent so will retry tomorrow.

@estenberg
Copy link
Contributor

Bad news: meta-intel is broken (intel/linux-intel-lts#4).
Good news: Your patch works flawlessly!

Tested on Minnowboard turbot with these storage settings:

MENDER_STORAGE_DEVICE = "/dev/mmcblk2"
MENDER_GRUB_STORAGE_DEVICE = "hd0"

Used meta-mender sumo with the commit from this PR cherry-picked.

Copy link
Contributor

@estenberg estenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not comment on code, but works!

@estenberg
Copy link
Contributor

Would be awesome if this can go into sumo as well :)

@kacf kacf merged commit c5a071f into mendersoftware:master Aug 22, 2018
@kacf kacf deleted the grub_storage_device branch August 22, 2018 11:35
@kacf
Copy link
Member Author

kacf commented Aug 22, 2018

Would be awesome if this can go into sumo as well :)

It will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants