[WC-2518]: Fix slider-web tooltip positioning #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
force-pushed
the
fix/WC-2518_slider_tooltip_issue
branch
from
84b0b79
to
c4b27c1
Compare
gjulivan
reviewed
Jun 18, 2024
packages/pluggableWidgets/slider-web/src/utils/createHandleGenerator.tsx
Show resolved
Hide resolved
rahmanunver
force-pushed
the
fix/WC-2518_slider_tooltip_issue
branch
from
c4b27c1
to
b86c1b2
Compare
rahmanunver
force-pushed
the
fix/WC-2518_slider_tooltip_issue
branch
from
8c4537a
to
ed772e0
Compare
r0b1n
approved these changes
Jun 21, 2024
leonardomendix
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Same fix applied in #1118 for
range-slider-webAdded
getTooltipContainermethod from rc-slider to keep the tooltip in its containing element instead of rendering up in the body.What should be covered while testing?
The tooltip should be following the slider.