Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC-2537] chore(shared-charts): add code minification #1122

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

iobuhov
Copy link
Collaborator

@iobuhov iobuhov commented Jun 19, 2024

Pull request type

No code changes (changes to documentation, CI, metadata, etc.)


Description

Add tarser plugin to shared charts to reduce plotly bundle size. This change makes resulting mpk way smaller.

What should be covered while testing?

  • Build Charts.mpk from this branch. The restulting mpk should have smaller size then mpk v5.0.0

@iobuhov iobuhov requested a review from a team as a code owner June 19, 2024 10:03
@iobuhov iobuhov force-pushed the WC-2537/charts-code-minification branch from 3e10e60 to cb4af2a Compare June 27, 2024 11:55
@iobuhov iobuhov changed the title chore(shared-charts): add code minification [WC-2537] chore(shared-charts): add code minification Jun 27, 2024
@iobuhov iobuhov force-pushed the WC-2537/charts-code-minification branch from cb4af2a to d57acbd Compare July 2, 2024 07:51
@iobuhov iobuhov merged commit 66aa9a7 into main Jul 2, 2024
14 checks passed
@iobuhov iobuhov deleted the WC-2537/charts-code-minification branch July 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants